[JTC] Cleanup API #1128
Open
[JTC] Cleanup API #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
fmauch,
jaron-l,
olivier-stasse and
progtologist
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last bullet point and closes #944.
The methods
all used class variables, like dof_ and so on. I moved them to a separate file as proposed, and wrote additional unit tests.
I used the JTC-GPL-parameter struct as function arguments, but this makes these methods not really standalone without JTC.
The logic is almost identical, except for
sort_to_local_joint_orderwhere I also updated the joint_names field// might not be used any more, but to get a genuine msg trajectory_msg->joint_names = params.joints;